Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] remove macos install hack for colima #1594

Merged
merged 7 commits into from
Dec 9, 2023
Merged

[CI] remove macos install hack for colima #1594

merged 7 commits into from
Dec 9, 2023

Conversation

clangenb
Copy link
Member

@clangenb clangenb commented Dec 8, 2023 •
edited
Loading

Don't run brew update before installing colima, and simply ignore the harmless linker error.

  • This removes some instability issues we have observed with the newest colima version, closes Unstable MacOs CI #1581
  • It also makes the CI 5–15 minutes faster.

@clangenb clangenb added A2-technical PR introduces technical changes B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes labels Dec 8, 2023
@clangenb clangenb merged commit fe0c819 into master Dec 9, 2023
14 of 17 checks passed
@clangenb clangenb deleted the cl/check-if-macos-ci-hack-can-be-removed branch December 9, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A2-technical PR introduces technical changes B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable MacOs CI
1 participant
@clangenb