Contacts after updating #1337
Closed
Contacts after updating #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azackmatoff
added
A1-bugfix
clangenb
approved these changes
Jul 4, 2023
Comment on lines
+107
to
+113
| final name = Community.fromCid(appStore.encointer.community?.cid.toFmtString()).name; | ||
| if (name == 'No Name' || name.toLowerCase().contains('no name')) { | ||
| return context.l10n.unknown; | ||
| } else { | ||
| return name; | ||
| } | ||
| } |
There was a problem hiding this comment.
I am quite sure that the community can never have this No Name. Do you have information that I am wrong?
There was a problem hiding this comment.
I checked for community and couldn't see anything with No Name names))), but still wasn't sure so added this code.
Comment on lines
+47
to
+52
| if (contact.address == counterParty) { | ||
| if (contact.name == 'No Name' || contact.name.toLowerCase().contains('no name')) { | ||
| return context.l10n.unknown; | ||
| } | ||
| return contact.name; | ||
| } |
There was a problem hiding this comment.
Oh wow, so the no names, were actually because there were accounts that had No Name as a name because it was the default choice? This was a tricky one. XD
There was a problem hiding this comment.
I did go through codes and couldn't find anyplace where No Name would come up, so thought maybe it's here)))
|
The actual fix is here: #1376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.