Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename settings.contactListAll to settings.allStoredAccounts #1372

Closed
clangenb opened this issue Jul 14, 2023 · 0 comments · Fixed by #1397
Closed

Rename settings.contactListAll to settings.allStoredAccounts #1372

clangenb opened this issue Jul 14, 2023 · 0 comments · Fixed by #1397

Comments

@clangenb
Copy link
Member

The name is wrong because contactListAll contains the addresses of all accounts on the phone and all contacts on the phone. So we should rename the field to:

/// All addresses stored on the device.
///
/// It contains the accounts and the contacts stored on the device.
@computed
List<AccountData> get contactListAll {
  return List<AccountData>.of(rootStore.account.accountList)..addAll(contactList);
}
@clangenb clangenb changed the title Rename settings.contactListAll to settings.allStoredAddresses Rename settings.contactListAll to settings.allStoredAccounts Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant