enabled more lint (#996)

* cloned app

* enabled  no_default_cases: true

analysis_options.yaml

@@ -6,7 +6,7 @@ linter:
     directives_ordering: false
     sort_pub_dependencies: false
     flutter_style_todos: false
-    no_default_cases: false
+    no_default_cases: true
     use_named_constants: false
     avoid_positional_boolean_parameters: false
     comment_references: false

flutterw

@@ -4,7 +4,7 @@
 ##
 ##  Flutter start up script for UN*X
 ##  Version: v1.3.1
-##  Date: 2022-12-22 21:01:55
+##  Date: 2023-02-08 19:57:46
 ##
 ##  Use this flutter wrapper to bundle Flutter within your project to make
 ##  sure everybody builds with the same version.

lib/page-encointer/bazaar/menu/camera/image_picker_scaffold.dart

@@ -36,18 +36,12 @@ class ImagePickerScaffold extends StatelessWidget {
                       );
                     case ConnectionState.done:
                       return const ImagePreview();
-                    default:
-                      if (snapshot.hasError) {
-                        return Text(
-                          'Pick image/video error: ${snapshot.error}}',
-                          textAlign: TextAlign.center,
-                        );
-                      } else {
-                        return Text(
-                          I18n.of(context)!.translationsForLocale().bazaar.imageNotPicked,
-                          textAlign: TextAlign.center,
-                        );
-                      }
+                    //Here I'll need your help
+                    case ConnectionState.active:
+                      return Text(
+                        I18n.of(context)!.translationsForLocale().bazaar.imageNotPicked,
+                        textAlign: TextAlign.center,
+                      );
                   }
                 },
               )

lib/page-encointer/ceremony_box/ceremony_box.dart

@@ -188,9 +188,6 @@ Widget getMeetupInfoWidget(BuildContext context, AppStore store) {
           );
         }
       }
-    default:
-      Log.d("'getMeetupInfoWidget' trapped in an unexpected default case", 'CeremonyBox');
-      return Container();
   }
 }
 

lib/page/assets/transfer/payment_confirmation_page/index.dart

@@ -208,8 +208,6 @@ class _PaymentConfirmationPageState extends State<PaymentConfirmationPage> with
             ),
           ),
         );
-      default:
-        return const Text('Unknown transfer state');
     }
   }
 
@@ -253,8 +251,6 @@ class _PaymentConfirmationPageState extends State<PaymentConfirmationPage> with
             style: h2Grey,
           );
         }
-      default:
-        return const Text('Unknown transfer state');
     }
   }
 

lib/page/qr_scan/qr_scan_service.dart

@@ -37,8 +37,6 @@ class QrScanService {
         return InvoiceQrCode.fromQrFields(data);
       case QrCodeContext.voucher:
         return VoucherQrCode.fromQrFields(data);
-      default:
-        throw const FormatException('[parseQrScan] Unhandled qr scan context');
     }
   }
 
@@ -50,8 +48,6 @@ class QrScanService {
         return handleInvoiceQrCodeScan(context, scanContext, qrCode as InvoiceQrCode);
       case QrCodeContext.voucher:
         return handleVoucherQrCodeScan(context, scanContext, qrCode as VoucherQrCode);
-      default:
-        throw const FormatException('[handleQrScan] Unhandled qr scan context');
     }
   }
 }

lib/service/deep_link/deep_link.dart

@@ -59,8 +59,5 @@ Future<void> _navigationWithWrScanContext(BuildContext context, QrCode<dynamic>
         ReapVoucherPage.route,
         arguments: ReapVoucherParams(voucher: qrCode.data as VoucherData),
       );
-      break;
-    default:
-      break;
   }
 }

lib/service/tx/lib/src/submit_to_js.dart

@@ -132,6 +132,9 @@ void _onTxFinish(
 }
 
 String getTxStatusTranslation(TranslationsHome dic, TxStatus? status) {
+  if (status == null) {
+    return '';
+  }
   switch (status) {
     case TxStatus.Queued:
       return dic.txQueued;
@@ -145,9 +148,6 @@ String getTxStatusTranslation(TranslationsHome dic, TxStatus? status) {
       return dic.txInBlock;
     case TxStatus.Error:
       return dic.txError;
-    default:
-      Log.d('Illegal TxStatus supplied to translation: $status', 'getTxStatusTranslation');
-      return '';
   }
 }
 

lib/store/encointer/encointer.dart

@@ -509,8 +509,6 @@ abstract class _EncointerStore with Store {
         return nextPhaseTimestamp! -
             phaseDurations[CeremonyPhase.Attesting]! -
             phaseDurations[CeremonyPhase.Assigning]!;
-      default:
-        return null;
     }
   }