Add wide format support to cl_fix_in_range #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
harry-commin-enclustra
commented
Jul 6, 2021
harry-commin-enclustra
commented
- To avoid code duplication (which seems to have led to unexplained inconsistency with cl_fix_resize), I just followed the python implementation (which calls cl_fix_resize explicitly).
- The VHDL testbench still passes. However, if any new failure is found, then the python implementation must be fixed in parallel.
- I have not checked synthesis (and I don't see an obvious use case for this function in synthesis). I would expect synthesis to be sane, but some optimization may be needed.
- To avoid code duplication (which seems to have led to unexplained inconsistency with cl_fix_resize), I just followed the python implementation (which calls cl_fix_resize explicitly). - The VHDL testbench still passes. However, if any new failure is found, then the python implementation must be fixed in parallel. - I have not checked synthesis (and I don't see an obvious use case for this function in synthesis). I would expect synthesis to be sane, but some optimization may be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.