Skip to content

WRR-26401: ImageItem: Added slotBefore #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 6, 2025
Merged

Conversation

alexandrumorariu
Copy link
Contributor

@alexandrumorariu alexandrumorariu commented Jun 17, 2025

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

I added a prop slotBefere, to better customize the ImageItem in our component libraries.

Resolution

Additional Considerations

Links

WRR- 26401

Comments

@alexandrumorariu alexandrumorariu changed the title WRR- 26401: ImageItem - implement new showSelection design WRR-26401: ImageItem - implement new showSelection design Jun 17, 2025
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (0fbab0c) to head (789157c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3334   +/-   ##
========================================
  Coverage    82.12%   82.13%           
========================================
  Files          153      153           
  Lines         7122     7124    +2     
  Branches      1877     1879    +2     
========================================
+ Hits          5849     5851    +2     
  Misses         999      999           
  Partials       274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

alexandrumorariu and others added 2 commits June 18, 2025 13:11
Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
@MikyungKim MikyungKim changed the title WRR-26401: ImageItem - implement new showSelection design WRR-26401: ImageItem: Added slotBefore Jul 5, 2025
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikyungKim MikyungKim merged commit 0e35f10 into develop Jul 6, 2025
8 checks passed
@MikyungKim MikyungKim deleted the feature/WRR-26401 branch July 6, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants