Skip to content

RUST-BUG-109: close ED2K callback and server parity gaps - #69

Merged
itlezy merged 37 commits into
mainfrom
fix/rust-bug-109-ed2k-audit-remediation
Oct 11, 2026
Merged

itlezy merged 37 commits into
mainfrom
fix/rust-bug-109-ed2k-audit-remediation

Conversation

@itlezy

@itlezy itlezy commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • close the ED2K callback and server state-machine gaps tracked by RUST-BUG-109
  • adopt callback transports into live peer sessions with route-scoped, expiring authorization
  • make bounded server packet failures request-local and preserve authenticated sessions
  • retain LowID upload queue entitlement across direct-UDP and exact shared-server callbacks
  • fence shared-server callback dispatch by endpoint, login generation, and current local HighID

Protocol evidence

Static comparison covered community eMule, aMule, ed2k-server-rust, maintained eMuleBB MFC behavior, and the Lugdunum 17.15 decompile. Stock/community wire behavior remains authoritative; maintained MFC improvements are retained where they strengthen admission or upload-grant preservation.

Validation

  • cargo test -p emulebb-ed2k -p emulebb-core
    • 1,019 emulebb-ed2k unit tests
    • 394 emulebb-core unit tests
    • integration and doc tests
  • cargo check -p emulebb-ed2k -p emulebb-core --all-targets
  • cargo clippy -p emulebb-ed2k -p emulebb-core --all-targets -- -D warnings -A unfulfilled-lint-expectations -D clippy::allow_attributes
  • cargo fmt --all -- --check
  • git diff --check

Threepwood-7 added 30 commits October 11, 2026 15:04
@itlezy

itlezy commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

Tracking and closure documentation: emulebb/emulebb-tooling#8

@itlezy
itlezy merged commit a5ccebc into main Oct 11, 2026
14 checks passed
@itlezy
itlezy deleted the fix/rust-bug-109-ed2k-audit-remediation branch October 11, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant