Auto notch #758
Closed
Auto notch #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
TODO add settings to the parameter_names.h file and add this to the blackbox header files. Also add this to the osd. |
defaults may still need tweaking
Member
|
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autonotch is code that automatically decides how much the notch filter is crossfaded with its input signal. By determining the amount of noise at the notch frequency we can set up a limit. As noise approaches that limit the notch filter is used more, as noise is low it isn't used. This will automatically phase out rpm and dynamic notch filters that to do not have much use. This should reduce delay and turn off the effect of notch filters that are doing nothing.
To test you have new rpm_noise_limit, and dyn_notch_noise_limit, both of which determine how much noise can pass through before the notch filter is fully turned on. A higher value allows more noise to pass through before the notch filter takes full effect, smaller values happen sooner.