-
-
Notifications
You must be signed in to change notification settings - Fork 117
Add alti limiter For french Regulation #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Quick-Flash <46289813+Quick-Flash@users.noreply.github.com>
* Update feature.h (#232) * increment version number to 0.3.1 (#235) * Update feature.h * Update version.h Co-authored-by: loutwice <loutwice@gmail.com> * Added additional battery voltage field to OSD (fixed average battery voltage in DJI osd) Co-authored-by: Quick-Flash <46289813+Quick-Flash@users.noreply.github.com> Co-authored-by: loutwice <loutwice@gmail.com>
* Update feature.h (#232) * increment version number to 0.3.1 (#235) * Update feature.h * Update version.h Co-authored-by: loutwice <loutwice@gmail.com> * Remove a filter made for FF (#239) FF has been removed so this filter should as well. * symbole was added in the altitude field. so buff need to be align Co-authored-by: Quick-Flash <46289813+Quick-Flash@users.noreply.github.com>
* Update feature.h (#232) * increment version number to 0.3.1 (#235) * Update feature.h * Update version.h Co-authored-by: loutwice <loutwice@gmail.com> * Remove a filter made for FF (#239) FF has been removed so this filter should as well. * fix as seen in betaflight -thanks Co-authored-by: Quick-Flash <46289813+Quick-Flash@users.noreply.github.com> Co-authored-by: BERTHOMIER Manuel <MBERTHOMIER@cafat.nc>
|
@loutwice please make it all conditional this time. this should not break with the |
| #include "drivers/io.h" | ||
|
|
||
| #include "io/motors.h" | ||
| #include "io/gps.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind flash space.
|
|
||
| #include "rx/rx.h" | ||
|
|
||
| #include "sensors/barometer.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few have barometer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok got it ! thanks @gretel i will improve this
src/main/flight/mixer.c
Outdated
|
|
||
| loggingThrottle = throttle; | ||
|
|
||
| #ifdef USE_BARO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also depends on USE_GPS at least.
|
|
||
| uint8_t getThrottleLimitationStatus(void) | ||
| { | ||
| return altiLimStatus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please name either the function or the variable according to it's sibiling.
|
|
||
|
|
||
| // Check for healthy communications | ||
| bool gpsIsHealthy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to declare functions for a single occurance. this can be done inline.
| #include "flight/position.h" | ||
| #include "flight/imu.h" | ||
| #ifdef USE_ESC_SENSOR | ||
| //#ifdef USE_ESC_SENSOR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? please add comments if this is intendend.
|
@loutwice please test by building the |
|
was reading mail not attending the automated builds.. |
|
@binarylefmart is attempting some work on this code. |
i have this code since few month now - testing by shikijo and some others testers
it add a setting on/off for activating an altitude limiter
it works with two settings :
alti_start_lim ( values from which the throttle will be decreased if reached )
alti_cutoff ( values from which the throttle will be inactive if reached )
once the quad back to authorized altitude play back with the throttle to regain normal behavior