Skip to content

Conversation

@loutwice
Copy link
Contributor

i have this code since few month now - testing by shikijo and some others testers
it add a setting on/off for activating an altitude limiter

it works with two settings :
alti_start_lim ( values from which the throttle will be decreased if reached )
alti_cutoff ( values from which the throttle will be inactive if reached )

once the quad back to authorized altitude play back with the throttle to regain normal behavior

loutwice and others added 12 commits March 6, 2020 07:21
Co-authored-by: Quick-Flash <46289813+Quick-Flash@users.noreply.github.com>
* Update feature.h (#232)

* increment version number to 0.3.1 (#235)

* Update feature.h

* Update version.h

Co-authored-by: loutwice <loutwice@gmail.com>

* Added additional battery voltage field to OSD (fixed average battery voltage in DJI osd)

Co-authored-by: Quick-Flash <46289813+Quick-Flash@users.noreply.github.com>
Co-authored-by: loutwice <loutwice@gmail.com>
* Update feature.h (#232)

* increment version number to 0.3.1 (#235)

* Update feature.h

* Update version.h

Co-authored-by: loutwice <loutwice@gmail.com>

* Remove a filter made for FF (#239)

FF has been removed so this filter should as well.

* symbole was added in the altitude field. so buff need to be align

Co-authored-by: Quick-Flash <46289813+Quick-Flash@users.noreply.github.com>
* Update feature.h (#232)

* increment version number to 0.3.1 (#235)

* Update feature.h

* Update version.h

Co-authored-by: loutwice <loutwice@gmail.com>

* Remove a filter made for FF (#239)

FF has been removed so this filter should as well.

* fix as seen in betaflight -thanks

Co-authored-by: Quick-Flash <46289813+Quick-Flash@users.noreply.github.com>
Co-authored-by: BERTHOMIER Manuel <MBERTHOMIER@cafat.nc>
@gretel
Copy link
Contributor

gretel commented Jul 16, 2020

@loutwice please make it all conditional this time. this should not break with the f3 builds, again.

#include "drivers/io.h"

#include "io/motors.h"
#include "io/gps.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind flash space.


#include "rx/rx.h"

#include "sensors/barometer.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few have barometer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got it ! thanks @gretel i will improve this


loggingThrottle = throttle;

#ifdef USE_BARO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also depends on USE_GPS at least.


uint8_t getThrottleLimitationStatus(void)
{
return altiLimStatus;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please name either the function or the variable according to it's sibiling.



// Check for healthy communications
bool gpsIsHealthy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to declare functions for a single occurance. this can be done inline.

#include "flight/position.h"
#include "flight/imu.h"
#ifdef USE_ESC_SENSOR
//#ifdef USE_ESC_SENSOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? please add comments if this is intendend.

@gretel
Copy link
Contributor

gretel commented Oct 7, 2020

@loutwice please test by building the OMNIBUS target which is F3

@loutwice
Copy link
Contributor Author

loutwice commented Oct 7, 2020

@loutwice please test by building the OMNIBUS target which is F3

hi @gretel ! yes i am currently working on this part ! i didn't think my commit will trigger a build !
sorry about that

@gretel
Copy link
Contributor

gretel commented Oct 7, 2020

was reading mail not attending the automated builds..

@loutwice loutwice marked this pull request as draft May 12, 2021 03:21
@nerdCopter
Copy link
Member

@binarylefmart is attempting some work on this code.
35d3ca498b952055422a2dba1d132706fb334816 seems to be the last working commit in the branch

@nerdCopter nerdCopter added the enhancement Minor enhancement to code label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Minor enhancement to code help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants