Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourmash: init at 4.8.11 #288

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

sourmash: init at 4.8.11 #288

wants to merge 3 commits into from

Conversation

luizirber
Copy link
Contributor

@luizirber luizirber commented Mar 12, 2023 •
edited
Loading

Similar PR in pyodide: pyodide/pyodide#3635

Mostly copied deps from https://github.com/conda-forge/sourmash-minimal-feedstock instead of what I did for pyodide, do I need to bring in the "pure python" deps too (or those can be pulled from conda-forge/PyPI?)

Note: this has a Rust extension, not sure if it works yet in emscripten-forge 😅

@wolfv
Copy link
Contributor

wolfv commented Mar 12, 2023

Nice! I think @DerThorsten did some work recently to enable rust on emscripten forge so there is a chance :)

@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch from e1f6918 to e95fcef Compare March 12, 2023 22:20
@wolfv
Copy link
Contributor

wolfv commented Mar 12, 2023

Regarding pure python deps – everything that is available as a noarch package on conda-forge should work fine!

@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch from e95fcef to ed1bed9 Compare March 12, 2023 22:25
@DerThorsten
Copy link
Contributor

@wolfv @luizirber I am working on support for rust pyo3 packages but its not yet working

@luizirber
Copy link
Contributor Author

@wolfv @luizirber I am working on support for rust pyo3 packages but its not yet working

Nice!

Quick comment: sourmash is not a rust pyo3 package, it uses cffi for the bindings. It does use maturin as the build backend, which is more commonly used with pyo3 bindings.

@luizirber luizirber mentioned this pull request Apr 6, 2023
Open
@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch from ed1bed9 to 77978e4 Compare April 6, 2023 16:27
@luizirber luizirber changed the title sourmash: init at 4.7.0 sourmash: init at 4.8.0 Apr 6, 2023
@luizirber luizirber marked this pull request as ready for review April 13, 2023 15:07
@luizirber luizirber mentioned this pull request Apr 14, 2023
Open
@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch from 77978e4 to 78fd8ec Compare April 25, 2023 21:20
@luizirber luizirber changed the title sourmash: init at 4.8.0 sourmash: init at 4.8.2 Apr 25, 2023
@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch from 78fd8ec to a3ae7e5 Compare September 28, 2023 00:10
@luizirber luizirber changed the title sourmash: init at 4.8.2 sourmash: init at 4.8.4 Sep 28, 2023
@luizirber
Copy link
Contributor Author

This has been open for some time, I updated to sourmash 4.8.4 but I didn't see any movement in the Rust support, so I don't think this will work yet =]

@DerThorsten
Copy link
Contributor

this needs to be converted to the new rattler-recipe format

Also rust packages with maturin are working now

@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch from 38267c8 to 3c7f3b2 Compare July 3, 2024 15:33
@luizirber luizirber changed the title sourmash: init at 4.8.4 sourmash: init at 4.8.10 Jul 3, 2024
@DerThorsten
Copy link
Contributor

the error might be there because we use the a nightly version of the rust compiler tkaitchuck/aHash#200

I try to have a more detailed look on monday

@luizirber luizirber mentioned this pull request Jul 8, 2024
Merged
@luizirber
Copy link
Contributor Author

I ran cargo update -p ahash and got v0.7.8 in sourmash now, as of sourmash-bio/sourmash#3243

when we release a new version there (probably 4.8.11) I'll update the PR here.

luizirber added a commit to sourmash-bio/sourmash that referenced this pull request Jul 9, 2024
@luizirber
bump ahash to 0.7.8, nix flake update (#3243)
687fdf5 
Fix for emscripten-forge/recipes#288

Also update nix dependencies
@luizirber luizirber mentioned this pull request Jul 26, 2024
Closed
@luizirber luizirber changed the title sourmash: init at 4.8.10 sourmash: init at 4.8.11 Aug 1, 2024
@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch 5 times, most recently from 828e50d to 5a263de Compare August 1, 2024 00:28
@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch from 5a263de to 89e5b5d Compare August 1, 2024 00:33
@luizirber luizirber mentioned this pull request Aug 1, 2024
Closed
15 tasks
@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch from b3c5231 to af8df1f Compare August 9, 2024 05:01
emscripten-forge-bot and others added 3 commits September 30, 2024 13:26
@emscripten-forge-bot @luizirber
Update swiglpk from 5.0.4 to 5.0.5 (emscripten-forge#984)
745ccc8 
Co-authored-by: emscripten-forge-bot <emscripten-forge-bot@users.noreply.github.com>
@luizirber
sourmash: init at 4.8.11
08f8943
@luizirber
disable branchwater feature
077cd23
@luizirber luizirber force-pushed the lirber/sourmash_4.7.0 branch from af8df1f to 077cd23 Compare September 30, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luizirber @wolfv @DerThorsten @emscripten-forge-bot