Add option --override-repository #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like flake8 is run using python2? |
|
Yes, emsdk, unlike emscripten itself still needs to support python2 I believe so that it can bootstrap itself successfully on macOS where python2 comes pre-installed in the path but not python3. |
sbc100
reviewed
Apr 19, 2021
sbc100
reviewed
Apr 19, 2021
|
Updated according to review, ptal. |
radekdoulik
referenced
this pull request
in dotnet/emsdk
May 20, 2021
* Add option --override-repository to allow controlling where git clones happen from. * Address review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option --override-repository to allow controlling where git clones happen from.
With this method we can integrate emsdk builds to our CI.