Repository navigation
[bazel] Remove asmjs / -sWASM=0 support - #1806
Merged
Merged
Conversation
Emscripten is on track to remove this feature: emscripten-core/emscripten#27608
sbc100
commented
Oct 6, 2026
| implementation = _impl, | ||
| attrs = { | ||
| "cpu": attr.string(mandatory = True, values = ["asmjs", "wasm"]), | ||
| "cpu": attr.string(mandatory = True, values = ["wasm"]), |
Collaborator
Author
There was a problem hiding this comment.
I guess we could completely remove this field now? Perhaps as a followup.
Collaborator
Author
There was a problem hiding this comment.
(I guess we should probably add wasm64 here so maybe worth keeping ?)
Member
There was a problem hiding this comment.
yeah if this is where wasm64 goes, might as well keep it.
4 of 6 tasks
dschuff
approved these changes
Oct 6, 2026
dschuff
left a comment
dschuff
left a comment
Member
There was a problem hiding this comment.
LGTM I guess but I have no idea about bazel :D
DoDoENT
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emscripten is on track to remove this feature:
emscripten-core/emscripten#27608