Skip to content

Fix the format of the .flake8 file, and exclude the script directory from the py2 linter #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 24, 2023

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Aug 24, 2023

Flake8's INI config file format requires commas after each line. Because our file didn't have them, the exclude list
wasn't set up correctly, and the --extend-exclude flag wasn't working. This PR fixes the .flake8 file.

Also, update flake8 to the latest version available (because version 3.8 is required to get the --extend-exclude flag)
and use the flag to exclude the files in the scripts/ directory from the python2 linter (since the scripts are python3).

@dschuff dschuff requested a review from sbc100 August 24, 2023 00:41
@dschuff dschuff merged commit 5d347a6 into main Aug 24, 2023
@dschuff dschuff deleted the lintertest branch August 24, 2023 16:17
shlomif pushed a commit to shlomif/emsdk that referenced this pull request Sep 29, 2023
…from the py2 linter (emscripten-core#1272)

Flake8's INI config file format requires commas after each line. Because our file didn't have them, the exclude list
wasn't set up correctly, and the --extend-exclude flag wasn't working. This PR fixes the .flake8 file.

Also, update flake8 to the latest version available (because version 3.8 is required to get the --extend-exclude flag)
and use the flag to exclude the files in the scripts/ directory from the python2 linter (since the scripts are python3).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants