Prefer arm64 over aarch64 internally. NFC
#1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like more commonly known/used name for the architecture these days.
dschuff
approved these changes
Jun 27, 2023
| @@ -141,12 +141,17 @@ def exit_with_error(msg): | |||
| elif machine.endswith('86'): | |||
| ARCH = 'x86' | |||
| elif machine.startswith('aarch64') or machine.lower().startswith('arm64'): | |||
| ARCH = 'aarch64' | |||
| if WINDOWS: | |||
| errlog('No support for Windows on Arm, fallback to x64') | |||
There was a problem hiding this comment.
would this actually work? i.e. does Windows ARM64 have automatic emulation the way MacOS does?
There was a problem hiding this comment.
I assume so.. I just moved this code from below, I didn't create or change it.
shlomif
pushed a commit
to shlomif/emsdk
that referenced
this pull request
Sep 29, 2023
This seems like more commonly known/used name for the architecture these days.
rachelmsimm
pushed a commit
to rachelmsimm/emsdk
that referenced
this pull request
Feb 22, 2025
juj
pushed a commit
to Unity-Technologies/emsdk
that referenced
this pull request
Feb 27, 2025
* Update mac arm64 version of node * Add debug log * Try add new main sdk version * Clarify architecture * Remove architecture specification * Remove log * Cherry pick commit: Prefer `arm64` over `aarch64` internally. NFC (emscripten-core#1246) * Remove extra new line * Use older node version for intel mac --------- Co-authored-by: Sam Clegg <sbc@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like more commonly known/used name for the architecture these days.