Add setting fields to control which browser versions to support #9937
Conversation
juj
force-pushed
the
remove_experimental_webgl_support
branch
from
c84318b to
190573d
Compare
|
Couple of fixes, and added a |
There was a problem hiding this comment.
Direction looks good, but I think we need a decision on our legacy support, as discussed in the other issue.
Specifically, I think by default we should not have 0 as the default for MIN. We should support only a reasonable amount of backwards compatibility by default, and not til the beginning of time. Users that do actually want support that far back can flip a flag.
Concretely, I'm suggesting:
- The default values of MIN should be something reasonable that captures 99% or so of users total. So chrome can be 6 months ago from today, firefox should have the last supported ESR I guess, etc.
- Add a section in emcc.py that checks if
LEGACY_VM_SUPPORTis enabled, and sets the MIN versions to 0 if so.
|
Sure - updated, how does that look? |
juj
force-pushed
the
remove_experimental_webgl_support
branch
from
9d5e859 to
fbd923d
Compare
There was a problem hiding this comment.
Great!
Please also mention in the LEGACY_VM_SUPPORT comment that it does this (the comment explains everything the option does),
Line 501 in 0fae35a
…ripten-core#9937) * Add setting fields to control which browser versions to support, and apply it to experimental-webgl. * Remove Internet Explorer backwards compatibility when IE is not targeted. * Remove infinity const * Add support for -s OLDEST_SUPPORTED_X_VERSION=-1 and add a test * OLDEST_SUPPORTED_ -> MIN_ * Remove MIN_IOS_SAFARI_VERSION, better to introduce it only when/if needed. * Set default for browser version support * Document LEGACY_VM_SUPPORT effect
Add setting fields to control which browser versions to support, and apply it to experimental-webgl.