Update fetch dependencies #9743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See like fetch depends on emscripten_is_main_browser_thread and not on emscripten_is_main_runtime_thread. I'm not sure how write a test for this but is came up as part of #9740.
sbc100
force-pushed
the
fix_fetch_deps
branch
from
0788558 to
d0f0b52
Compare
kripken
approved these changes
Oct 30, 2019
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
See like fetch depends on emscripten_is_main_browser_thread and not on emscripten_is_main_runtime_thread. I'm not sure how write a test for this but is came up as part of emscripten-core#9740.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like fetch depends on
emscripten_is_main_browser_threadand noton
emscripten_is_main_runtime_thread.I'm not sure how write a test for this but is came up as part of
#9740.