Remove now-unnecessary PthreadWorkerInit #9656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
reviewed
Oct 17, 2019
| @@ -23,12 +23,7 @@ | |||
| // (using makeStaticAlloc) | |||
|
|
|||
| LibraryManager.library = { | |||
| // keep this low in memory, because we flatten arrays with them in them | |||
| #if USE_PTHREADS | |||
| _impure_ptr: '; if (ENVIRONMENT_IS_PTHREAD) __impure_ptr = PthreadWorkerInit["__impure_ptr"]; else PthreadWorkerInit["__impure_ptr"] = {{{ makeStaticAlloc(4) }}}', | |||
There was a problem hiding this comment.
so _impure_ptr is just all in wasm now?
There was a problem hiding this comment.
Yeah, that was some weird JS detail due to how we handled older versions of musl - this particular code has been dead for quite some time.
There was a problem hiding this comment.
(There is no more impure_ptr in the codebase at all.)
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
That extra complexity is no longer needed after recent simplifications. This ends up making the pthreads and non-pthreads paths more similar too. This saves 338 bytes, which more than makes up for the slight regression of 77 bytes from emscripten-core#9569.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That extra complexity is no longer needed after recent simplifications. This ends up making the pthreads and non-pthreads paths more similar too.
This saves 338 bytes, which more than makes up for the slight regression of 77 bytes from #9569.