Do not set mediump precision on vertex shaders #8628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertex shaders in webgl default to highp
kainino0x
approved these changes
May 17, 2019
|
ensurePrecision was used for both vertex and fragment shaders. This PR removes its usage for vertex shaders where it's not needed. |
|
Ah, sorry, I tried to search for other usages and I failed. LGTM |
This change relates to legacy GL emulation, where source fragment shaders may come in without a precision qualifier, but in WebGL fragment shaders, precision qualifiers are mandatory. So to emulate, one is added automatically. LGTM to remove the precision qualifier from WebGL vertex shaders, that is not required (unlike WebGL fragment shaders do) |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…ipten-core#8628) Vertex shaders in webgl default to highp. And vertex shaders (unlike fragment shaders) do not need a precision, so we don't need to add one there.
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vertex shaders in webgl default to highp
#8627