Fix WebGL context attribute handling and Chrome workaround #7996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix WebGL context attribute handling for enableExtensionsByDefault and explicitSwapControl, and work around Chrome behavior that it does not return powerPreference in context attributes.
CC @kainino0x and @kenrussell (and @jdashg ) : it looks like when one creates a WebGL context with context attributes
powerPreference
field set in Chrome, and then later callson the created context, the returned
attributes
object does not have thatpowerPreference
field. I don't know what the spec says if it should be there, but looks like in Firefox thepowerPreference
field is present.This PR makes Emscripten return
"default"
as powerPreference if browser did not provide it.Also adds unrelated quote fixes for Closure compilation.