Add leading underscore to implemented functions in wasm_backend #4854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
dschuff
approved these changes
Jan 12, 2017
jgravelle-google
force-pushed
the
wasm_implemented_funcs_underscore
branch
from
f59df13 to
cf56e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a fun bug where if your C code used
lround, thenlroundis implemented in terms ofround, which is imported from JS. Because we were trimming the leading character that wasn't an underscore, we thought the module already implementedround, and didn't actually import it, which caused the module to fail to instantiate.Depends on #4813 to fix the printf formatting for
test_emscripten_api.