Repository navigation
Conversation
`wasm2js` was marked as deprecated in emscripten-core#27655. This change removes support for compiling to JavaScript via `wasm2js` (`-sWASM=0` and `-sWASM=2`), moving `WASM` to `LEGACY_SETTINGS` with `[1]` as the only valid value. Also remove `src/wasm2js.js`, `tools/js_optimizer.py`, and the `minifyGlobals`, `minifyLocals`, and `emitSymbolMap` passes in `tools/acorn-optimizer.mjs`. In addition to removing the 6 `wasm2js*` core test suites and `wasm2js` parameterized test variants (including `@also_with_wasm2js`), this removes 57 test methods: - 39 `@only_wasm2js` tests in `test/test_core.py` that tested basic C/C++ codegen (such as `i64` arithmetic, `va_arg`, bitfields, and float conversions) which were only kept for `wasm2js` coverage since LLVM already tests its own Wasm codegen upstream. - 12 `wasm2js`-specific tests across `test/test_core.py` (2), `test/test_other.py` (6), and `test/test_browser.py` (4) that directly tested `-sWASM=0` or `-sWASM=2`. - 3 `tools/js_optimizer.py` tests in `test/test_other.py`, since the Python JS optimizer wrapper was only used by the `wasm2js` pipeline. - 2 long-skipped fastcomp `invoke_*` tests in `test/test_other.py`. - 1 `test_preallocated_heap` test in `test/test_browser.py`, which tested preallocating a plain `ArrayBuffer` (`Module['buffer']`) with `-sWASM=0` (an asm.js-era feature not applicable to Wasm). Fixes: emscripten-core#27608
sbc100
changed the title
WASM=0 and WASM=2)WASM=0 and WASM=2)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasm2jswas marked as deprecated in #27655. This change removessupport for compiling to JavaScript via
wasm2js(-sWASM=0and-sWASM=2), movingWASMtoLEGACY_SETTINGSwith[1]as the onlyvalid value.
Also remove
src/wasm2js.js,tools/js_optimizer.py, and theminifyGlobals,minifyLocals, andemitSymbolMappasses intools/acorn-optimizer.mjs.In addition to removing the 6
wasm2js*core test suites andwasm2jsparameterized test variants (including
@also_with_wasm2js), thisremoves 57 test methods:
@only_wasm2jstests intest/test_core.pythat tested basicC/C++ codegen (such as
i64arithmetic,va_arg, bitfields, andfloat conversions) which were only kept for
wasm2jscoverage sinceLLVM already tests its own Wasm codegen upstream.
wasm2js-specific tests acrosstest/test_core.py(2),test/test_other.py(6), andtest/test_browser.py(4) thatdirectly tested
-sWASM=0or-sWASM=2.tools/js_optimizer.pytests intest/test_other.py, since thePython JS optimizer wrapper was only used by the
wasm2jspipeline.invoke_*tests intest/test_other.py.test_preallocated_heaptest intest/test_browser.py, whichtested preallocating a plain
ArrayBuffer(Module['buffer']) with-sWASM=0(an asm.js-era feature not applicable to Wasm).Fixes: #27608