Make wasm-sourcemap.py faster #25935
Open
+75
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. This replaces uses of `Pattern.split` with `Pattern.finditer`. 2. In `extract_func_ranges`, instead of splitting the whole text into single tags first and searches `DW_TAG_(subprogram|inlined_subroutine)` in each of them, we search the pattern from the whole text using `finditer` and tries to parse a tag from each match. This improves running time on `wasm-opt.wasm` by ~18% (14.9s -> 12.2s).
sbc100
reviewed
Dec 11, 2025
| try: | ||
| current_match = next(iterator) | ||
| except StopIteration: | ||
| return map_stmt_list_to_comp_dir |
Collaborator
There was a problem hiding this comment.
Can you skip the try/catch and just do current_match = next(iterator, None)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pattern.splitwithPattern.finditer.extract_func_ranges, instead of splitting the whole text into single tags first and searchesDW_TAG_(subprogram|inlined_subroutine)in each of them, we search the pattern from the whole text usingfinditerand tries to parse a tag from each match.This improves running time on
wasm-opt.wasmby ~18% (14.9s -> 12.2s).