Disabled test_std_filesystem_{tempdir_}wasmfs_rawfs. NFC#25861
Disabled test_std_filesystem_{tempdir_}wasmfs_rawfs. NFC#25861sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
These tests depend on being able to access arbitrary paths which doesn't currently work with NODERAWFS + WASMFS. See emscripten-core#18820
|
These tests happened to pass on linux + noderawfs + wasmfs in our CI because it happens to work went TMP/TMPDIR happen to point to |
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
removing the win/mac check is ok because NODERAWFS is just always unset on those platforms?
This change only effects NODERAWFS +WASMFS versions of the test. This change just makes them skip on all OSes because they basically don't work in the general case due to limitations of WASMFS. |
|
For reference, the issue related to absolute path access (when using |
|
Thanks @kleisauke I will update those |
…core#25861) These tests depend on being able to access arbitrary paths which doesn't currently work with NODERAWFS + WASMFS. See emscripten-core#18820
3 participants
These tests depend on being able to access arbitrary paths which doesn't currently work with NODERAWFS + WASMFS.
See #18820