Avoid using a new temp directory for each parallel test. NFC #25615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be fine for all parallel tests to using the same TEMP_DIR. The only limitation is on tests that use the canonical test directory (e.g. EMCC_DEBUG). It looks like we used to use a unique temp directory per process (See emscripten-core#6150). However that we changes to one-directory-per-test in emscripten-core#18214, although I don't remember why. With this change we don't create a new temp directory except for tests that are marked as `uses_canonical_tmp`
sbc100
force-pushed
the
temp_temp_dir_clean
branch
from
9fc5106 to
ca6adaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be fine for all parallel tests to using the same TEMP_DIR.
The only limitation is on tests that use the canonical test directory (e.g. EMCC_DEBUG).
It looks like we used to use a unique temp directory per process (See #6150). However that we changes to one-directory-per-test in #18214, although I don't remember why.
With this change we don't create a new temp directory except for tests that are marked as
uses_canonical_tmp