Make wasmOffsetConvert usage more localized in libstack_trace.js. NFC
#24599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this while investigating emscripten-core#24587.
kripken
approved these changes
Jun 17, 2025
Comment on lines
+118
to
119
| #endif | ||
| return wasmOffsetConverter.convert(+match[1], +match[2]); |
There was a problem hiding this comment.
Suggested change
| #endif | |
| return wasmOffsetConverter.convert(+match[1], +match[2]); | |
| return wasmOffsetConverter.convert(+match[1], +match[2]); | |
| #endif |
May as well only emit it when it is enabled.
There was a problem hiding this comment.
That is the case already... this code is already part of the #else block right?
There was a problem hiding this comment.
Oh sorry, I missed the if for ASSERTIONS... lgtm as is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while investigating #24587.