-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Use global TLS variable in proxying.c. NFC #24596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to update the rest of the file to use bools? It seems best to be consistent one way or the other.
There is already existing use of stdbool, for example:
And:
I don't see many more opportunities to use |
Also use `bool` rather than `int` to better convey intent. Split out from emscripten-core#24565
I found one more :) |
Lines 141 and 410 are the other candidates I see. |
This don't work so well as they are basically underlying parts of public interfaces that return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was some suspicion that this might lead to a code size change but it doesn't seem to (I suppose because bool/int doesn't have any code in its constructor).
Also use
bool
rather thanint
to better convey intent.Split out from #24565