Update wasm_offset_converter. NFC

[sbc100]

• Convert to ES class
• Use string templates

[sbc100]

View with "hide whitespace"

[RReverser]

But is it still necessary at all? (see #24587, I think it can be just removed nowadays?)

[sbc100]

Yes, I was inspired to create this while trying to figure out if this is still needed.

My guess is that it is still needed for things ASAN, but I will do some more investigation.

[RReverser]

If you're referring to usage in

emscripten/src/lib/libstack_trace.js

Lines 112 to 120 in 39d93be

	if (match = /\bwasm-function\[\d+\]:(0x[0-9a-f]+)/.exec(frame)) {
	// some engines give the binary offset directly, so we use that as return address
	return +match[1];
	} else if (match = /\bwasm-function\[(\d+)\]:(\d+)/.exec(frame)) {
	// other engines only give function index and offset in the function,
	// so we try using the offset converter. If that doesn't work,
	// we pack index and offset into a "return address"
	return wasmOffsetConverter.convert(+match[1], +match[2]);
	} else if (match = /:(\d+):\d+(?:\)|$)/.exec(frame)) {

, then first branch should be sufficient nowadays as stacktrace format was standardised as part of Web API.

[sbc100]

You may well the correct yes, but can we land this change anyway, and attempt to delete this code as a followup?

[RReverser]

It does feel a bit like unnecessary work if it turns out we can delete it right after, but sure, why not :)

[sbc100]

It does feel a bit like unnecessary work if it turns out we can delete it right after, but sure, why not :)

I think I agree, but since I already did it ...