Skip to content

Reduce usage of POINTER_TYPE in JS library code #24586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reduce usage of POINTER_TYPE in JS library code #24586

wants to merge 1 commit into from

Conversation

RReverser
Copy link
Collaborator

Same as #24490 but for the 17 usages of SIZE_TYPE which should always be the same as *.

@RReverser
Reduce usage of POINTER_TYPE in JS library code
53bba69 
Same as emscripten-core#24490 but for the 17 usages of SIZE_TYPE which should always be the same as `*`.
@RReverser RReverser requested a review from sbc100 June 17, 2025 11:45
@sbc100
Copy link
Collaborator

sbc100 commented Jun 17, 2025

I was thinking I would prefer to keep SIZE_TYPE, but instead make be semantically the same as *. I have a PR to that effect but it was running into issues.

@RReverser
Copy link
Collaborator Author

RReverser commented Jun 17, 2025 •
edited
Loading

I was thinking I would prefer to keep SIZE_TYPE, but instead make be semantically the same as *.

Maybe we could add an actual string literal to reflect it then? Both usize (for current SIZE_TYPE) and isize (for current LONG_TYPE) could be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 Awaiting requested review from sbc100

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RReverser @sbc100