Enable libc++ error messages in debug builds #24543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
sbc100
added a commit
to sbc100/llvm-project
that referenced
this pull request
Jun 10, 2025
This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap` From what I can tell neither of these function expect a trailing newline (At least non of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except _LIBCPP_ASSERTION_HANDLER). I noticed this discrepancy when working on emscripten-core/emscripten#24543
|
I filed llvm/llvm-project#143573 upstream in llvm to see if we can avoid carrying the libc++ patch going forward. |
sbc100
added a commit
to sbc100/llvm-project
that referenced
this pull request
Jun 10, 2025
This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap` From what I can tell neither of these function expect a trailing newline (At least non of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except _LIBCPP_ASSERTION_HANDLER). I noticed this discrepancy when working on emscripten-core/emscripten#24543
sbc100
added a commit
to sbc100/llvm-project
that referenced
this pull request
Jun 10, 2025
This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap` From what I can tell neither of these function expect a trailing newline (At least non of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except _LIBCPP_ASSERTION_HANDLER). I noticed this discrepancy when working on emscripten-core/emscripten#24543
sbc100
added a commit
to sbc100/llvm-project
that referenced
this pull request
Jun 10, 2025
This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap` From what I can tell neither of these function expect a trailing newline (At least non of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except _LIBCPP_ASSERTION_HANDLER). I noticed this discrepancy when working on emscripten-core/emscripten#24543
kripken
approved these changes
Jun 10, 2025
sbc100
force-pushed
the
verbose_abort
branch
4 times, most recently
from
4275051 to
1b48188
Compare
dschuff
reviewed
Jun 10, 2025
| // passed to __libcpp_verbose_abort. The _LIBCPP_VERBOSE_ABORT macro seems to never use | ||
| // newlines, but _LIBCPP_ASSERTION_HANDLER does include a newline. | ||
| if (format[strlen(format) - 1] != '\n') { | ||
| std::fprintf(stderr, "\n"); |
There was a problem hiding this comment.
this could be std::fputs instead?
sbc100
added a commit
to sbc100/llvm-project
that referenced
this pull request
Jun 10, 2025
This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap` From what I can tell neither of these function expect a trailing newline (At least non of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except _LIBCPP_ASSERTION_HANDLER). I noticed this discrepancy when working on emscripten-core/emscripten#24543
sbc100
added a commit
to sbc100/llvm-project
that referenced
this pull request
Jun 10, 2025
This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap` From what I can tell neither of these function expect a trailing newline (At least non of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except _LIBCPP_ASSERTION_HANDLER). I noticed this discrepancy when working on emscripten-core/emscripten#24543
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 10, 2025
Feedback from emscripten-core#24543
sbc100
added a commit
to sbc100/llvm-project
that referenced
this pull request
Jun 11, 2025
This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap` From what I can tell neither of these function expect a trailing newline (At least non of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except _LIBCPP_ASSERTION_HANDLER). I noticed this discrepancy when working on emscripten-core/emscripten#24543
sbc100
added a commit
to sbc100/llvm-project
that referenced
this pull request
Jun 12, 2025
This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap` From what I can tell neither of these function expect a trailing newline (At least non of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except _LIBCPP_ASSERTION_HANDLER). I noticed this discrepancy when working on emscripten-core/emscripten#24543
ldionne
pushed a commit
to llvm/llvm-project
that referenced
this pull request
Jun 17, 2025
…#143573) This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap`. From what I can tell neither of these function expect a trailing newline (at least none of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except `_LIBCPP_ASSERTION_HANDLER`). I noticed this discrepancy when working on emscripten-core/emscripten#24543
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jun 17, 2025
…NDLER calls (#143573) This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap`. From what I can tell neither of these function expect a trailing newline (at least none of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except `_LIBCPP_ASSERTION_HANDLER`). I noticed this discrepancy when working on emscripten-core/emscripten#24543
fschlimb
pushed a commit
to fschlimb/llvm-project
that referenced
this pull request
Jun 18, 2025
…llvm#143573) This newline was originally added in https://reviews.llvm.org/D142184 but I think updating `__libcpp_verbose_abort` to add newline instead is more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`. The `_LIBCPP_ASSERTION_HANDLER` calls through to either `_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap`. From what I can tell neither of these function expect a trailing newline (at least none of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap` that I can find include a trailing newline except `_LIBCPP_ASSERTION_HANDLER`). I noticed this discrepancy when working on emscripten-core/emscripten#24543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24541