Skip to content

Remove/fix usage of MIN_SAFARI_VERSION #24423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
May 28, 2025
Merged

Remove/fix usage of MIN_SAFARI_VERSION #24423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/libemval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ var LibraryEmVal = {
return id;
},

#if MIN_CHROME_VERSION < 49 || MIN_FIREFOX_VERSION < 42 || MIN_SAFARI_VERSION < 100101
#if MIN_CHROME_VERSION < 49 || MIN_FIREFOX_VERSION < 42
$reflectConstruct: null,
$reflectConstruct__postset: `
if (typeof Reflect != 'undefined') {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/libhtml5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ var LibraryHTML5 = {
}
orientationAngle = screenOrientObj.angle;
}
#if MIN_SAFARI_VERSION < 0x100400
#if MIN_SAFARI_VERSION < 160400
else {
// fallback for Safari earlier than 16.4 (March 2023)
orientationAngle = window.orientation;
Expand Down
5 changes: 2 additions & 3 deletions tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,10 +1264,9 @@ def limit_incoming_module_api():
settings.MIN_SAFARI_VERSION < 140000 or
settings.MIN_NODE_VERSION < 160000)

# https://caniuse.com/class: FF:45 CHROME:49 SAFARI:9
# https://caniuse.com/class: FF:45 CHROME:49
supports_es6_classes = (settings.MIN_FIREFOX_VERSION >= 45 and
settings.MIN_CHROME_VERSION >= 49 and
settings.MIN_SAFARI_VERSION >= 90000)
settings.MIN_CHROME_VERSION >= 49)

if not settings.DISABLE_EXCEPTION_CATCHING and settings.EXCEPTION_STACK_TRACES and not supports_es6_classes:
diagnostics.warning('transpile', '-sEXCEPTION_STACK_TRACES requires an engine that support ES6 classes.')
Expand Down