Skip to content

Display core time and wallclock times when test suite finishes, to be able to easily observe/benchmark test suite speedup optimizations. #24396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions test/parallel_testsuite.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def combine_results(self, result, buffered_results):
# Sort the results back into alphabetical order. Running the tests in
# parallel causes mis-orderings, this makes the results more readable.
results = sorted(buffered_results, key=lambda res: str(res.test))
result.core_time = 0
for r in results:
r.updateResult(result)
return result
Expand All @@ -102,18 +103,21 @@ class BufferedParallelTestResult:
"""
def __init__(self):
self.buffered_result = None
self.test_duration = 0

@property
def test(self):
return self.buffered_result.test

def addDuration(self, test, elapsed):
pass
def calculateDuration(self):
self.test_duration = time.perf_counter() - self.start_time
return self.test_duration

def updateResult(self, result):
result.startTest(self.test)
self.buffered_result.updateResult(result)
result.stopTest(self.test)
result.core_time += self.test_duration

def startTest(self, test):
self.start_time = time.perf_counter()
Expand All @@ -122,21 +126,21 @@ def stopTest(self, test):
# TODO(sbc): figure out a way to display this duration information again when
# these results get passed back to the TextTestRunner/TextTestResult.
if hasattr(time, 'perf_counter'):
self.buffered_result.duration = time.perf_counter() - self.start_time
self.buffered_result.duration = self.test_duration

def addSuccess(self, test):
if hasattr(time, 'perf_counter'):
print(test, '... ok (%.2fs)' % (time.perf_counter() - self.start_time), file=sys.stderr)
print(test, '... ok (%.2fs)' % (self.calculateDuration()), file=sys.stderr)
self.buffered_result = BufferedTestSuccess(test)

def addExpectedFailure(self, test, err):
if hasattr(time, 'perf_counter'):
print(test, '... expected failure (%.2fs)' % (time.perf_counter() - self.start_time), file=sys.stderr)
print(test, '... expected failure (%.2fs)' % (self.calculateDuration()), file=sys.stderr)
self.buffered_result = BufferedTestExpectedFailure(test, err)

def addUnexpectedSuccess(self, test):
if hasattr(time, 'perf_counter'):
print(test, '... unexpected success (%.2fs)' % (time.perf_counter() - self.start_time), file=sys.stderr)
print(test, '... unexpected success (%.2fs)' % (self.calculateDuration()), file=sys.stderr)
self.buffered_result = BufferedTestUnexpectedSuccess(test)

def addSkip(self, test, reason):
Expand Down
8 changes: 8 additions & 0 deletions test/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import random
import sys
import unittest
import time

# Setup

Expand Down Expand Up @@ -348,13 +349,20 @@ def run_tests(options, suites):
else:
testRunner = unittest.TextTestRunner(verbosity=2, failfast=options.failfast)

total_core_time = 0
run_start_time = time.perf_counter()
for mod_name, suite in suites:
print('Running %s: (%s tests)' % (mod_name, suite.countTestCases()))
res = testRunner.run(suite)
msg = ('%s: %s run, %s errors, %s failures, %s skipped' %
(mod_name, res.testsRun, len(res.errors), len(res.failures), len(res.skipped)))
num_failures += len(res.errors) + len(res.failures) + len(res.unexpectedSuccesses)
resultMessages.append(msg)
if hasattr(res, 'core_time'):
total_core_time += res.core_time
total_run_time = time.perf_counter() - run_start_time
if total_core_time > 0:
print('Total core time: %.3fs. Wallclock time: %.3fs. Parallelization: %.2fx.' % (total_core_time, total_run_time, total_core_time / total_run_time))

if len(resultMessages) > 1:
print('====================')
Expand Down