Refactor browser.test_runtime_misuse. NFC #24391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
commented
May 21, 2025
| } | ||
|
|
||
| void free(void* ptr) { // free is valid to call even after the runtime closes, so useful as a hack here for this test | ||
| EM_ASM({ out(['reporting', $0]) }, noted); |
There was a problem hiding this comment.
This function was never used.. and the rest of this file is that same is as
test/test_runtime_misuse.c (except without main)
There was a problem hiding this comment.
Looks like call to free was removed in 3ddc9f2 but not the function itself.
kripken
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is still quite hard to understand, but at least it doesn't have any loops.