Add full expected JS output test_codesize_minimal_O0 #24390
Conversation
|
This change is built on top of #24387 .. please just review the second commit. |
In other codesize tests we commit JS for optimised files only, so that at least any DCE'd code does not appear in the diffs. Do you think it's worthwhile to do the same here or is O0 intentional? |
This file will be quite volatile since it will change on almost any change to the code JS code we generate. However it will make is much easier to see the effect of changes like emscripten-core#24384. Also, it should not be any more of less volatile than the existing code size expectations files and, like those, this file is updated automatically using the `--rebaseline` test flag.
I'm doing -O0 intentionally so that the JS is readable. If figure if we want to see the effect on the generated code and review it that O0 build would be best. We can extend this it future. |
sbc100
force-pushed
the
expected_js_output
branch
from
607b9a2 to
17813f3
Compare
|
Okay, fine by me, but I'll leave the review to @kripken for one more opinion. |
This file will be quite volatile since it will change on almost any
change to the code JS code we generate. However it will make is much
easier to see the effect of changes like #24384.
Also, it should not be any more of less volatile than the existing code
size expectations files and, like those, this file is updated
automatically using the
--rebaselinetest flag.