[ASYNCIFY] Avoid dependency on the names of exports #24382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kripken .. the one test that fails with this change is This is because I can think of some ways I might be able to make ASYNCIFY_LAZY_LOAD_CODE work in with this patch.. but I'm also tempted to simple remove it? WDYT? |
kripken
approved these changes
May 20, 2025
sbc100
force-pushed
the
asyncify_no_wasmExports
branch
from
212561b to
d10207a
Compare
|
I managed to make |
sbc100
force-pushed
the
asyncify_no_wasmExports
branch
from
d10207a to
eee7240
Compare
kripken
approved these changes
May 20, 2025
sbc100
force-pushed
the
asyncify_no_wasmExports
branch
from
eee7240 to
c27badd
Compare
This change moves from using export names to function identity to track the function in the resumption stack. The upside of this is that we can wrap non-exports, such as table entire, which we currently avoid by enabling `-sDYNCALLS` whenever `ASYNCIFY=1` is used. It also means we can potentially make `ASYNCIFY=1` work with the `wasmExports` global existing (i.e. in `WASM_ESM_INTEGRATION` mode.
sbc100
force-pushed
the
asyncify_no_wasmExports
branch
from
c27badd to
371489c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves from using export names to function identity to track the functions in the resumption stack.
The upside of this is that we can wrap non-exports, such as table entire, which we currently avoid by enabling
-sDYNCALLSwheneverASYNCIFY=1is used.It also means we can potentially make
ASYNCIFY=1work with thewasmExportsglobal existing (i.e. inWASM_ESM_INTEGRATIONmode.