Install SDL2/SDL3 cmake config only when installing the ports #24306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll probably land #24308 first we we can move these files alongside the config headers. |
kripken
reviewed
May 12, 2025
sbc100
force-pushed
the
sdl_cmake_config_files
branch
from
114f71d to
48ef633
Compare
|
Ok, now that we are storing these files alongside the ports this change might make more sense. |
kripken
approved these changes
May 12, 2025
The cmake config files are logically part of the ports so install them then the port is installed. This doesn't fix emscripten-core#19780 completely, since trying to build an SDL2 or SDL3 cmake project will still require some kind of install step, but it makes it less confusing.
sbc100
force-pushed
the
sdl_cmake_config_files
branch
from
48ef633 to
855671c
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 22, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 22, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 22, 2025
sbc100
added a commit
that referenced
this pull request
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmake config files are logically part of the ports so install them then the port is installed
This doesn't fix #19780 completely, since trying to build an SDL2 or SDL3 cmake project will still require some kind of install step, but it makes it less confusing.