Improve err/out implementation for node pthreads. NFC #23999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
node_pthread_console
branch
from
f342581 to
e9c2a79
Compare
sbc100
force-pushed
the
node_pthread_console
branch
2 times, most recently
from
c708398 to
5977d2e
Compare
kripken
approved these changes
Mar 27, 2025
| @@ -1 +1 @@ | |||
| 4037 | |||
| 4045 | |||
There was a problem hiding this comment.
Code size increase seems fine as this is just for node.js (and pthreads) logic.
sbc100
force-pushed
the
node_pthread_console
branch
from
5977d2e to
ea38e3f
Compare
sbc100
changed the title
We were overriding err in two different places. The overridden version of node was not correctly formatting its arguments. i.e. all objects were showing up as `[object Object]`
sbc100
force-pushed
the
node_pthread_console
branch
from
ea38e3f to
95e2c90
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 23, 2025
This was accidentally changed to stdout in emscripten-core#23999. Oops. Fixed: emscripten-core#24403
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 23, 2025
This was accidentally changed to stdout in emscripten-core#23999. Oops. Fixed: emscripten-core#24403
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 23, 2025
This was accidentally changed to stdout in emscripten-core#23999. Oops. Fixed: emscripten-core#24403
sbc100
added a commit
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console overrides for node were not correctly formatting their arguments. i.e. all objects were showing up as
[object Object]