Move some Module object assertions. NFC #23995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
module_env_check
branch
from
ff3fcf0 to
23ee272
Compare
brendandahl
approved these changes
Mar 26, 2025
kripken
approved these changes
Mar 26, 2025
sbc100
changed the title
This moves this assertion alongside other similar checks.
sbc100
force-pushed
the
module_env_check
branch
from
23ee272 to
c2aefa3
Compare
|
It looks like Maybe it looked like a flake but it wasn't? |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 27, 2025
sbc100
added a commit
that referenced
this pull request
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves these assertion alongside other similar checks.