Cleanup the emscripten tests relating to the event loop. NFC #23760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
event_loop_tests
branch
2 times, most recently
from
f2af566 to
6970efe
Compare
sbc100
changed the title
sbc100
force-pushed
the
event_loop_tests
branch
3 times, most recently
from
295f2fc to
c1a2f16
Compare
kripken
reviewed
Feb 25, 2025
sbc100
force-pushed
the
event_loop_tests
branch
from
c1a2f16 to
a6b1367
Compare
sbc100
changed the title
kripken
reviewed
Feb 26, 2025
kripken
approved these changes
Feb 26, 2025
sbc100
force-pushed
the
event_loop_tests
branch
4 times, most recently
from
7646bf0 to
7a07dc3
Compare
The browser tests were only being run in `PROXY_TO_PTHREAD` mode for some reason even though these tests should pass on the main thread. In test_other the `PROXY_TO_PTHREAD` flags were being passed as args (rather then emcc_args). Likely a copy/paste bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser tests were only being run in
PROXY_TO_PTHREADmodefor some reason even though these tests should pass on the main thread.
In test_other the
PROXY_TO_PTHREADflags were being passed as args(rather then emcc_args). Likely a copy/paste bug.