[embind] Stricter function argument name checking #23524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distinguish between unknown argument list and the empty argument list when parsing function names. Also use early return to make the code a little more compact.
sbc100
commented
Jan 29, 2025
| throw new Error('Argument names should match number of parameters.'); | ||
| } | ||
|
|
||
| const args = []; | ||
| for (let i = argStart, x = 0; i < argTypes.length; i++) { | ||
| if (x < argsName.length) { | ||
| if (argsName) { |
There was a problem hiding this comment.
We know that argsName is the correct length thanks to the Error above, right?
brendandahl
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distinguish between unknown argument list and the empty argument list when parsing function names.
Also use early return to make the code a little more compact.