Convert instantiateAsync form callbacks to promises. NFC #23066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best viewed with "ignore whitespace" |
sbc100
force-pushed
the
instantiateAsync
branch
from
ae33933 to
51b5fe9
Compare
kripken
approved these changes
Dec 4, 2024
brendandahl
approved these changes
Dec 4, 2024
sbc100
force-pushed
the
instantiateAsync
branch
from
51b5fe9 to
8b6e6b7
Compare
sbc100
force-pushed
the
instantiateAsync
branch
2 times, most recently
from
76b04c9 to
ff39fbc
Compare
sbc100
force-pushed
the
instantiateAsync
branch
from
ff39fbc to
9cb0879
Compare
sbc100
force-pushed
the
instantiateAsync
branch
from
9cb0879 to
052f473
Compare
sbc100
added a commit
that referenced
this pull request
Dec 10, 2024
These get lowered away by babel when targetting older engines. Followup to #23066, with code size savings.
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…core#23066) I'll hoping to follow up with a conversion to using `await` here. The code size changes seem to be mostly a wash with some tests improving and others regressing by a few bytes.
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…-core#23068) These get lowered away by babel when targetting older engines. Followup to emscripten-core#23066, with code size savings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll hoping to follow up with a conversion to using
awaithere.The code size changes seem to be mostly a wash with some tests improving and others regressing by a few bytes.