Skip to content

Fix test_async_mainloop WRT to new clang warning regarding "main" decl. NFC #22351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix test_async_mainloop WRT to new clang warning regarding "main" decl. NFC #22351

merged 1 commit into from
Aug 9, 2024

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 9, 2024 •
edited
Loading

See #22336

@sbc100 sbc100 requested a review from dschuff August 9, 2024 20:32
@sbc100 sbc100 changed the title Fix test_async_mainloop WRT to new clang warning regarding "main" dec… Fix test_async_mainloop WRT to new clang warning regarding "main" decl. NFC Aug 9, 2024
dschuff
dschuff approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why this was extern C in the first place? were we trying to call main from JS?

@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 9, 2024

do you know why this was extern C in the first place? were we trying to call main from JS?

No idea no. In fact, I've removed the unneccary EMSCRIPTEN_KEEPALIVE too.

@sbc100 sbc100 merged commit 65e311b into emscripten-core:main Aug 9, 2024
1 of 12 checks passed
@sbc100 sbc100 deleted the fix_ci branch August 9, 2024 21:46
@dschuff dschuff mentioned this pull request Oct 29, 2024
Merged
@dschuff dschuff mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @dschuff