Skip to content

Set errno correctly during __stdio_close #22046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbc100 merged 1 commit into from
Jun 3, 2024
Merged

Set errno correctly during __stdio_close #22046

sbc100 merged 1 commit into from
Jun 3, 2024

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jun 3, 2024 •
edited
Loading

Fixes: #22033

@sbc100 sbc100 changed the title Set errno in fclose if underlying close syscall fails Fix __stdio_close to correctly set errno Jun 3, 2024
@sbc100 sbc100 requested a review from kripken June 3, 2024 15:13
@sbc100 sbc100 changed the title Fix __stdio_close to correctly set errno Set errno correctly during __stdio_close Jun 3, 2024
@sbc100 sbc100 merged commit e691941 into emscripten-core:main Jun 3, 2024
@sbc100 sbc100 deleted the fclose_errno branch June 3, 2024 16:52
msorvig pushed a commit to msorvig/emscripten that referenced this pull request Jun 4, 2024
@sbc100
Fix __stdio_close to correctly set errno (emscripten-core#22046)
67a8a0b 
Fixes: emscripten-core#22033
@dschuff dschuff mentioned this pull request Oct 29, 2024
Merged
@dschuff dschuff mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kripken kripken kripken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expect error if closing a file twice with ::close and ::fclose sequentially, but got nothing

2 participants

@sbc100 @kripken