Skip to content

Exclude 80-bit long double sources from compiler-rt #21657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Mar 30, 2024

This is the list of files using 80-bit long double: https://github.com/llvm/llvm-project/blob/6009708b4367171ccdbf4b5905cb6a803753fe18/compiler-rt/lib/builtins/CMakeLists.txt#L279-L294
(This file is from LLVM 17.0.6, which is currently our compiler-rt version)

We don't have 80-bit long doubles so it looks we can exclude them.

This is the list of files using 80-bit long double:
https://github.com/llvm/llvm-project/blob/6009708b4367171ccdbf4b5905cb6a803753fe18/compiler-rt/lib/builtins/CMakeLists.txt#L279-L294
(This file is from LLVM 17.0.6, which is currently our compiler-rt
 version)

We don't have 80-bit long doubles so it looks we can exclude them.
@aheejin aheejin marked this pull request as ready for review March 30, 2024 18:00
@aheejin
Copy link
Member Author

aheejin commented Mar 30, 2024

The CI failures here will be fixed after #21659.

@aheejin aheejin requested a review from sbc100 March 30, 2024 18:00
@aheejin aheejin changed the title Exclude 80-bit long double sources Exclude 80-bit long double sources from compiler-rt Mar 30, 2024
@aheejin aheejin merged commit 59cd5e5 into emscripten-core:main Apr 1, 2024
29 checks passed
@aheejin aheejin deleted the exclude_80bits branch April 1, 2024 18:17
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Apr 11, 2024
This is the list of files using 80-bit long double:
https://github.com/llvm/llvm-project/blob/6009708b4367171ccdbf4b5905cb6a803753fe18/compiler-rt/lib/builtins/CMakeLists.txt#L279-L294
(This file is from LLVM 17.0.6, which is currently our compiler-rt
 version)

We don't have 80-bit long doubles so it looks we can exclude them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants