Skip to content

fixed file:// protocol not working in Ports.fetch_project #21456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2024
Merged

fixed file:// protocol not working in Ports.fetch_project #21456

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1bfbda8
fixed file:// protocol
ypujante Feb 29, 2024
026f394
flake8 fix
ypujante Feb 29, 2024
bc7d666
reverted changes to test
ypujante Mar 1, 2024
84ecea0
Merge remote-tracking branch 'origin/main' into fix-port-fetch-local-…
ypujante Mar 1, 2024
5d35983
added comment
ypujante Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/ports/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,8 @@ def retrieve():
import requests
response = requests.get(url)
data = response.content
except ImportError:
except (ImportError, requests.exceptions.InvalidSchema):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does requests not support the file:// scheme? If so perhaps add a comment about that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# requests does not support 'file://' protocol and raises InvalidSchema
from urllib.request import urlopen
f = urlopen(url)
data = f.read()
Expand Down