Remove ERRNO_MESSAGES from JS library. NFC
#21172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #21170 |
sbc100
force-pushed
the
remove_errno_messages
branch
from
ad3e57b to
da69878
Compare
kripken
approved these changes
Jan 25, 2024
sbc100
force-pushed
the
remove_errno_messages
branch
2 times, most recently
from
ca4a164 to
8955fb3
Compare
|
Depends on llvm/llvm-project#80169 |
sbc100
force-pushed
the
remove_errno_messages
branch
from
8955fb3 to
7c61a6f
Compare
auto-merge was automatically disabled
January 31, 2024 19:09
Pull request was converted to draft
sbc100
force-pushed
the
remove_errno_messages
branch
from
7c61a6f to
7c3a06a
Compare
sbc100
force-pushed
the
remove_errno_messages
branch
3 times, most recently
from
5f48c7d to
8e0a51c
Compare
sbc100
force-pushed
the
remove_errno_messages
branch
from
8e0a51c to
acedaf2
Compare
The native `strerror()` function can be used instead in the two places that still depend on `ERRNO_MESSAGES`
sbc100
force-pushed
the
remove_errno_messages
branch
from
acedaf2 to
c3370d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native
strerror()function can be used instead in the twoplaces that still depend on
ERRNO_MESSAGES