-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial new INITIAL_HEAP
setting
#21071
Merged
Merged
Commits on Jan 15, 2024
-
Changes in default behavior: 1) INITIAL_HEAP is the new default for most builds. This means that there is an increase in the effective initial memory used by "sizeof(stack) + sizeof(static data)". In typical small applications this should be on the order of half a megabyte. 2) Because we cannot precisely calculate the amount of initial memory now, ASAN support will use the conservative upper estimate of MAXIMUM_MEMORY. This only affects ALLOW_MEMORY_GROWTH=0 builds. This change does not yet enable INITIAL_HEAP for builds that instantiate the memory in JS, e. g. with threading.
Configuration menu - View commit details
-
Copy full SHA for b43181e - Browse repository at this point
Copy the full SHA b43181eView commit details -
Comment out the memory size assert
It seems this wasn't working for not-MINIMAL_RUNTIME for similar reasons for some time already.
Configuration menu - View commit details
-
Copy full SHA for 79bf8d7 - Browse repository at this point
Copy the full SHA 79bf8d7View commit details -
The tests hardcode the initial memory amount. Make them robust against changes in defaults.
Configuration menu - View commit details
-
Copy full SHA for 4def2c7 - Browse repository at this point
Copy the full SHA 4def2c7View commit details -
Rebaseline a couple code size tests
1 byte increase due to this diff: - (memory (;0;) 256 256) + (memory (;0;) 258 32768) We no longer cap the maximum memory.
Configuration menu - View commit details
-
Copy full SHA for 5ddd199 - Browse repository at this point
Copy the full SHA 5ddd199View commit details
Commits on Jan 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d893b4d - Browse repository at this point
Copy the full SHA d893b4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79958b2 - Browse repository at this point
Copy the full SHA 79958b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4e3cfc - Browse repository at this point
Copy the full SHA a4e3cfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f994f46 - Browse repository at this point
Copy the full SHA f994f46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1433dd8 - Browse repository at this point
Copy the full SHA 1433dd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8b285e - Browse repository at this point
Copy the full SHA c8b285eView commit details -
Configuration menu - View commit details
-
Copy full SHA for eae41e0 - Browse repository at this point
Copy the full SHA eae41e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3da94a8 - Browse repository at this point
Copy the full SHA 3da94a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0906505 - Browse repository at this point
Copy the full SHA 0906505View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3786ec - Browse repository at this point
Copy the full SHA a3786ecView commit details
Commits on Jan 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3c76f5b - Browse repository at this point
Copy the full SHA 3c76f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for db45ed2 - Browse repository at this point
Copy the full SHA db45ed2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d71d239 - Browse repository at this point
Copy the full SHA d71d239View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47ec651 - Browse repository at this point
Copy the full SHA 47ec651View commit details -
Configuration menu - View commit details
-
Copy full SHA for b443e06 - Browse repository at this point
Copy the full SHA b443e06View commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0dc6457 - Browse repository at this point
Copy the full SHA 0dc6457View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a885f1 - Browse repository at this point
Copy the full SHA 9a885f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2cdd4e - Browse repository at this point
Copy the full SHA d2cdd4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a37cafe - Browse repository at this point
Copy the full SHA a37cafeView commit details
Commits on Feb 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1ce8cd6 - Browse repository at this point
Copy the full SHA 1ce8cd6View commit details
Commits on Mar 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a36cf25 - Browse repository at this point
Copy the full SHA a36cf25View commit details -
Use --no-growable-memory when memory growth is not allowed
Note that this will ignore user-supplied MAXIMUM_MEMORY when growth is disabled. This is consistent with existing behavior.
Configuration menu - View commit details
-
Copy full SHA for d89c454 - Browse repository at this point
Copy the full SHA d89c454View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea3b557 - Browse repository at this point
Copy the full SHA ea3b557View commit details -
Configuration menu - View commit details
-
Copy full SHA for d688893 - Browse repository at this point
Copy the full SHA d688893View commit details -
Implementing ALLOW_MEMORY_GROWTH=0 properly revealed an invalid assumption in the test: that MAXIMUM_MEMORY is respected under ALLOW_MEMORY_GROWTH=0 (default). Since this is not true, pass -sALLOW_MEMORY_GROWTH=1 alongside MAXIMUM_MEMORY.
Configuration menu - View commit details
-
Copy full SHA for 37eeea5 - Browse repository at this point
Copy the full SHA 37eeea5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.