Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial new INITIAL_HEAP setting #21071

Merged
merged 29 commits into from
Mar 1, 2024

Commits on Jan 15, 2024

  1. Initial INITIAL_HEAP support

    Changes in default behavior:
    1) INITIAL_HEAP is the new default for most builds.
       This means that there is an increase in the effective
       initial memory used by "sizeof(stack) + sizeof(static data)".
       In typical small applications this should be on the order
       of half a megabyte.
    2) Because we cannot precisely calculate the amount
       of initial memory now, ASAN support will use
       the conservative upper estimate of MAXIMUM_MEMORY.
       This only affects ALLOW_MEMORY_GROWTH=0 builds.
    
    This change does not yet enable INITIAL_HEAP for builds
    that instantiate the memory in JS, e. g. with threading.
    SingleAccretion committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    b43181e View commit details
    Browse the repository at this point in the history
  2. Comment out the memory size assert

    It seems this wasn't working for not-MINIMAL_RUNTIME
    for similar reasons for some time already.
    SingleAccretion committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    79bf8d7 View commit details
    Browse the repository at this point in the history
  3. Adjust a couple tests

    The tests hardcode the initial memory amount.
    Make them robust against changes in defaults.
    SingleAccretion committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    4def2c7 View commit details
    Browse the repository at this point in the history
  4. Rebaseline a couple code size tests

    1 byte increase due to this diff:
    
    -  (memory (;0;) 256 256)
    +  (memory (;0;) 258 32768)
    
    We no longer cap the maximum memory.
    SingleAccretion committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    5ddd199 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Configuration menu
    Copy the full SHA
    d893b4d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    79958b2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a4e3cfc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f994f46 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1433dd8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c8b285e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eae41e0 View commit details
    Browse the repository at this point in the history
  8. Also update the doc

    SingleAccretion committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    3da94a8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0906505 View commit details
    Browse the repository at this point in the history
  10. Merge fix...

    SingleAccretion committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    a3786ec View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    3c76f5b View commit details
    Browse the repository at this point in the history
  2. Rebaseline once more

    SingleAccretion committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    db45ed2 View commit details
    Browse the repository at this point in the history
  3. More rebaselining

    This is suspect...
    SingleAccretion committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d71d239 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    47ec651 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b443e06 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    0dc6457 View commit details
    Browse the repository at this point in the history
  2. Fix up the change log

    SingleAccretion committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    9a885f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2cdd4e View commit details
    Browse the repository at this point in the history
  4. Brush-ups

    SingleAccretion committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    a37cafe View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Configuration menu
    Copy the full SHA
    1ce8cd6 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    a36cf25 View commit details
    Browse the repository at this point in the history
  2. Use --no-growable-memory when memory growth is not allowed

    Note that this will ignore user-supplied MAXIMUM_MEMORY when
    growth is disabled. This is consistent with existing behavior.
    SingleAccretion committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d89c454 View commit details
    Browse the repository at this point in the history
  3. Change log fixup

    SingleAccretion committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ea3b557 View commit details
    Browse the repository at this point in the history
  4. Rebaseline a test

    SingleAccretion committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d688893 View commit details
    Browse the repository at this point in the history
  5. Test nits and fixes

    Implementing ALLOW_MEMORY_GROWTH=0 properly revealed
    an invalid assumption in the test: that MAXIMUM_MEMORY
    is respected under ALLOW_MEMORY_GROWTH=0 (default).
    
    Since this is not true, pass -sALLOW_MEMORY_GROWTH=1
    alongside MAXIMUM_MEMORY.
    SingleAccretion committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    37eeea5 View commit details
    Browse the repository at this point in the history