Remove explicit support for JAVA and running closure compiler via java #20919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
approved these changes
Dec 14, 2023
sbc100
force-pushed
the
remove_java
branch
2 times, most recently
from
0fbab35 to
d466694
Compare
kripken
reviewed
Dec 14, 2023
site/source/docs/building_from_source/verify_emscripten_environment.rst
Outdated
Show resolved
Hide resolved
The default is to use the native version of closure compiler. That is the only version we currently test. If folks want to do |
kripken
approved these changes
Dec 14, 2023
It should still be possible for a user to explictly run the java version of closure using `EMCC_CLOSURE_ARGS=--platform=java` or `--closure-args=--platform=java`, but this isn't something we need to have explict support for and its not something we test.
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Dec 15, 2023
We use the native version of closure compiler these days so we don't need to install java on windows IIUC. See emscripten-core/emscripten#20919
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Dec 15, 2023
We use the native version of closure compiler these days so we don't need to install java on windows IIUC. See emscripten-core/emscripten#20919
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 17, 2024
This is a partial revert of emscripten-core#20919. It turns out that we were still depending on falling back to the java version of closure compiler in some cases. Specifically, on macOS arm64 when Rosetta is not installed, we were falling back to the Java version since google-closure-compiler doesn't ship arm64 binaries. I imagine the same will be true of linux-arm64.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 17, 2024
This is a partial revert of emscripten-core#20919. It turns out that we were still depending on falling back to the java version of closure compiler in some cases. Specifically, on macOS arm64 when Rosetta is not installed, we were falling back to the Java version since google-closure-compiler doesn't ship arm64 binaries. I imagine the same will be true of linux-arm64.
sbc100
added a commit
that referenced
this pull request
Jan 17, 2024
This is a partial revert of #20919. It turns out that we were still depending on falling back to the java version of closure compiler in some cases. Specifically, on macOS arm64 when Rosetta is not installed, we were falling back to the Java version since google-closure-compiler doesn't ship arm64 binaries. I imagine the same will be true of linux-arm64.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 17, 2024
This change also reverts the changes made to test_other.py in emscripten-core#20919.
sbc100
added a commit
that referenced
this pull request
Jan 17, 2024
1 task
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Oct 28, 2024
We use the native version of closure compiler these days so we don't need to install java on windows IIUC. See emscripten-core/emscripten#20919
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Oct 29, 2024
We use the native version of closure compiler these days so we don't need to install java on windows IIUC. See emscripten-core/emscripten#20919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should still be possible for a user to explictly run the java version of closure using
EMCC_CLOSURE_ARGS=--platform=javaor--closure-args=--platform=java, but this isn't something we need to have explict support for and its not something we test.