Skip to content

Add #if ASSERTIONS around assert in library_async.js #20722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add #if ASSERTIONS around assert in library_async.js #20722

merged 1 commit into from
Nov 15, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 15, 2023

This fixes STRICT + ASYNCIFY + ASSERTIONS=0 builds.

Fixes: #20721

@sbc100
Add #if ASSERTIONS around assert in ibrary_async.js
b0dd799 
This fixes STRICT + ASYNCIFY + ASSERTIONS=0 builds.

Fixes: emscripten-core#20721
kripken
kripken approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title is missing "l" in "library"

@sbc100 sbc100 changed the title Add #if ASSERTIONS around assert in ibrary_async.js Add #if ASSERTIONS around assert in library_async.js Nov 15, 2023
@sbc100 sbc100 enabled auto-merge (squash) November 15, 2023 17:58
@sbc100 sbc100 merged commit 084611f into emscripten-core:main Nov 15, 2023
@sbc100 sbc100 deleted the fix_strict_asyncify branch November 15, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

@brendandahl brendandahl Awaiting requested review from brendandahl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to emsdk v3.1.48 breaking build
2 participants
@sbc100 @kripken