Skip to content

Re-enable wasm64+pthreads browser tests. NFC #20304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Re-enable wasm64+pthreads browser tests. NFC #20304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions test/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4754,9 +4754,7 @@ def test_fetch_cached_xhr(self):

# Tests that response headers get set on emscripten_fetch_t values.
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
# @also_with_wasm2js_or_wasm64
@also_with_wasm2js
@also_with_wasm2js_or_wasm64
@requires_threads
def test_fetch_response_headers(self):
shutil.copyfile(test_file('gears.png'), 'gears.png')
Expand Down Expand Up @@ -4789,9 +4787,7 @@ def test_fetch_xhr_abort(self):
# Tests emscripten_fetch() usage in synchronous mode when used from the main
# thread proxied to a Worker with -sPROXY_TO_PTHREAD option.
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
# @also_with_wasm2js_or_wasm64
@also_with_wasm2js
@also_with_wasm2js_or_wasm64
@requires_threads
def test_fetch_sync_xhr(self):
shutil.copyfile(test_file('gears.png'), 'gears.png')
Expand All @@ -4800,8 +4796,7 @@ def test_fetch_sync_xhr(self):
# Tests emscripten_fetch() usage when user passes none of the main 3 flags (append/replace/no_download).
# In that case, in append is implicitly understood.
@no_firefox('https://github.com/emscripten-core/emscripten/issues/16868')
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
# @also_with_wasm64
@also_with_wasm64
@requires_threads
def test_fetch_implicit_append(self):
shutil.copyfile(test_file('gears.png'), 'gears.png')
Expand Down Expand Up @@ -5634,8 +5629,7 @@ def test_full_js_library_strict(self):
# Tests the AudioWorklet demo
@parameterized({
'': ([],),
# TODO(sbc): https://github.com/emscripten-core/emscripten/issues/20262
# 'memory64': (['-sMEMORY64', '-Wno-experimental'],),
'memory64': (['-sMEMORY64', '-Wno-experimental'],),
'with_fs': (['--preload-file', test_file('hello_world.c') + '@/'],),
'closure': (['--closure', '1', '-Oz'],),
'asyncify': (['-sASYNCIFY'],),
Expand Down