Skip to content

[test] Simplify test_i64_val. NFC #20239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 8 additions & 30 deletions test/embind/test_i64_val.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,42 +6,21 @@
#include <stdio.h>
#include <iostream>
#include <sstream>
#include <cmath>
#include <emscripten/bind.h>
#include <emscripten/emscripten.h>
#include <emscripten/val.h>

using namespace emscripten;
using namespace std;

void fail()
{
cout << "fail\n";
}

void pass()
{
cout << "pass\n";
}

void test(string message)
{
void test(string message) {
cout << "test:\n" << message << "\n";
}

void ensure(bool value)
{
if (value)
pass();
else
fail();
}

void ensure_js(string js_code)
{
void ensure_js(string js_code) {
js_code.append(";");
const char* js_code_pointer = js_code.c_str();
ensure(EM_ASM_INT({
assert(EM_ASM_INT({
var js_code = UTF8ToString($0);
return eval(js_code);
}, js_code_pointer));
Expand All @@ -54,8 +33,7 @@ string compare_a_64_js(T value) {
return ss.str();
}

int main()
{
int main() {
const int64_t max_int64_t = numeric_limits<int64_t>::max();
const int64_t min_int64_t = numeric_limits<int64_t>::min();
const uint64_t max_uint64_t = numeric_limits<uint64_t>::max();
Expand All @@ -73,24 +51,24 @@ int main()

val::global().set("a", val(int64_t(0x12345678aabbccddL)));
ensure_js("a === 1311768467732155613n");
ensure(val::global()["a"].as<int64_t>() == 0x12345678aabbccddL);
assert(val::global()["a"].as<int64_t>() == 0x12345678aabbccddL);

test("val(uint64_t v)");
val::global().set("a", val(uint64_t(1234)));
ensure_js("a === 1234n");

val::global().set("a", val(max_uint64_t));
ensure_js(compare_a_64_js(max_uint64_t));
ensure(val::global()["a"].as<uint64_t>() == max_uint64_t);
assert(val::global()["a"].as<uint64_t>() == max_uint64_t);

test("val(int64_t v)");
val::global().set("a", val(max_int64_t));
ensure_js(compare_a_64_js(max_int64_t));
ensure(val::global()["a"].as<int64_t>() == max_int64_t);
assert(val::global()["a"].as<int64_t>() == max_int64_t);

val::global().set("a", val(min_int64_t));
ensure_js(compare_a_64_js(min_int64_t));
ensure(val::global()["a"].as<int64_t>() == min_int64_t);
assert(val::global()["a"].as<int64_t>() == min_int64_t);

test("val(typed_memory_view<uint64_t>)");
val::global().set("a", val(typed_memory_view(uint64Array.size(), uint64Array.data())));
Expand Down
19 changes: 0 additions & 19 deletions test/embind/test_i64_val.out
Original file line number Diff line number Diff line change
@@ -1,31 +1,12 @@
start
test:
val(int64_t v)
pass
pass
pass
pass
test:
val(uint64_t v)
pass
pass
pass
test:
val(int64_t v)
pass
pass
pass
pass
test:
val(typed_memory_view<uint64_t>)
pass
pass
pass
pass
test:
val(typed_memory_view<int64_t>)
pass
pass
pass
pass
end